Improvements from feed validation

diff --git a/README.md b/README.md
index d8105317b8eba187ff10d5426d30962ad985010c..846ade898dd800b8610636213273ec3c6af6b664 100644 (file)
--- a/README.md
+++ b/README.md
@@ -75,7 +75,7 @@ $ docker run --rm --network host kineto /app/kineto gemini://localhost
 To generate an RSS feed:
 
 ```
-$ ( cd gemini2rss/ ; poetry run python gemini2rss.py https://alex.corcoles.net 10 "El blog es mío" "https://alex.corcoles.net" ; ) >/tmp/feed.rss
+$ ( cd gemini2rss/ ; poetry run python gemini2rss.py https://alex.corcoles.net 10 "El blog es mío" "https://alex.corcoles.net" Alex alex@corcoles.net ; ) >/tmp/feed.rss
 ```
 
 ## Migrating a Wordpress blog to Gemini

diff --git a/gemini2rss/gemini2rss.py b/gemini2rss/gemini2rss.py
index 2db88bc5ef62af80b4a2f6b624650e0a71e881c4..3803be7f3b3544e8f8f095f1ecdb73c31c2300cb 100644 (file)
--- a/gemini2rss/gemini2rss.py
+++ b/gemini2rss/gemini2rss.py
@@ -10,6 +10,8 @@ url = sys.argv[1]
 feed_size = int(sys.argv[2])
 title = sys.argv[3]
 id = sys.argv[4]
+author_name = sys.argv[5]
+author_email = sys.argv[6]
 
 
 with urllib.request.urlopen(url) as f: 
@@ -22,7 +24,7 @@ posts = 0
 
 f = feed.FeedGenerator()
 f.title(title)
-f.id(id)
+f.id(id + "/")
 
 for a in soup.find_all("a"):
     if posts == feed_size:
@@ -35,8 +37,9 @@ for a in soup.find_all("a"):
     
     fi = f.add_item()
     fi.title(title)
-    fi.id(a["href"])
+    fi.id(url + a["href"])
     fi.link(href=a["href"])
+    fi.author(name=author_name, email=author_email)
     fi.updated(datetime.datetime.combine(date, datetime.datetime.min.time(), tzinfo=datetime.timezone.utc))
 
     node = a.parent.next_sibling
@@ -48,7 +51,7 @@ for a in soup.find_all("a"):
         if node and node.name == "h1" and node.string and node.string == "Sobre mí":
             break
         content += node if isinstance(node, bs4.NavigableString) else node.prettify() 
-    fi.content(content)
+    fi.content(content, type="html")
 
     posts += 1