From 9aeadbe40350e551c524943c24bd7994af58f381 Mon Sep 17 00:00:00 2001
From: alex <alex@pdp7.net>
Date: Sun, 15 Jan 2023 18:27:35 +0100
Subject: Simplify variable use, add fact support

---
 .../puppet/modules/dns_dhcp/manifests/init.pp      |  4 ++--
 .../puppet/modules/proxmox/manifests/init.pp       |  2 +-
 personal_infra/puppet/site/00-common.pp            | 24 +++++++++++-----------
 3 files changed, 15 insertions(+), 15 deletions(-)

(limited to 'personal_infra/puppet')

diff --git a/personal_infra/puppet/modules/dns_dhcp/manifests/init.pp b/personal_infra/puppet/modules/dns_dhcp/manifests/init.pp
index c7a35520..358633af 100644
--- a/personal_infra/puppet/modules/dns_dhcp/manifests/init.pp
+++ b/personal_infra/puppet/modules/dns_dhcp/manifests/init.pp
@@ -1,11 +1,11 @@
 class dns_dhcp {
-  $domain = lookup("'$ansible_inventory_hostname'.network.dns_dhcp.domain")
+  $domain = lookup("network.dns_dhcp.domain")
 
   package {'dnsmasq':}
   ->
   file {'/etc/dnsmasq.d/internal':
     content => epp('dns_dhcp/internal', {
-      'dns_dhcp' => lookup("'$ansible_inventory_hostname'.network.dns_dhcp"),
+      'dns_dhcp' => lookup("network.dns_dhcp"),
     }),
   }
   ~>
diff --git a/personal_infra/puppet/modules/proxmox/manifests/init.pp b/personal_infra/puppet/modules/proxmox/manifests/init.pp
index 21360368..0fa82d18 100644
--- a/personal_infra/puppet/modules/proxmox/manifests/init.pp
+++ b/personal_infra/puppet/modules/proxmox/manifests/init.pp
@@ -1,7 +1,7 @@
 class proxmox {
   file {'/etc/network/interfaces':
     content => epp('proxmox/interfaces', {
-      "network" => lookup("'$ansible_inventory_hostname'.network"),
+      "network" => lookup("network"),
     }),
   }
   ~>
diff --git a/personal_infra/puppet/site/00-common.pp b/personal_infra/puppet/site/00-common.pp
index c5023081..b542eb9e 100644
--- a/personal_infra/puppet/site/00-common.pp
+++ b/personal_infra/puppet/site/00-common.pp
@@ -1,28 +1,28 @@
 include automatic_updates
 
-$tinc_hosts = lookup("'$ansible_inventory_hostname'.groups.tinc")
-$tinc_other_hosts = $tinc_hosts.filter |$host_name| { $host_name != $ansible_inventory_hostname }
+$tinc_hosts = lookup("groups.tinc")
+$tinc_other_hosts = $tinc_hosts.filter |$host_name| { $host_name != $facts["networking"]["fqdn"] }
 
 $tinc_locations = Hash($tinc_hosts.map |$host_name| { [
-  lookup("'$host_name'.network.tinc.location"),
+  lookup("hostvars.'$host_name'.network.tinc.location"),
   {
-    subnet => lookup("'$host_name'.network.self_internal_network"),
-    address => lookup("'$host_name'.network.public_hostname"),
+    subnet => lookup("hostvars.'$host_name'.network.self_internal_network"),
+    address => lookup("hostvars.'$host_name'.network.public_hostname"),
   }
 ] })
 
-$tinc_connect_to = $tinc_other_hosts.map |$host_name| { lookup("'$host_name'.network.tinc.location") }
+$tinc_connect_to = $tinc_other_hosts.map |$host_name| { lookup("hostvars.'$host_name'.network.tinc.location") }
 
-$tinc_other_networks = $tinc_other_hosts.map |$host_name| { lookup("'$host_name'.network.self_internal_network") }
+$tinc_other_networks = $tinc_other_hosts.map |$host_name| { lookup("hostvars.'$host_name'.network.self_internal_network") }
 
-if 'tinc' in lookup("'$ansible_inventory_hostname'.group_names") {
+if 'tinc' in lookup("group_names") {
   class {'tinc':
-    tinc_name           => lookup("'$ansible_inventory_hostname'.tinc_global.name"),
-    tinc_location       => lookup("'$ansible_inventory_hostname'.network.tinc.location"),
+    tinc_name           => lookup("tinc_global.name"),
+    tinc_location       => lookup("network.tinc.location"),
     tinc_connect_to     => $tinc_connect_to,
     tinc_locations      => $tinc_locations,
-    tinc_ip             => lookup("'$ansible_inventory_hostname'.network.self_internal_ip"),
-    tinc_netmask        => lookup("'$ansible_inventory_hostname'.network.self_internal_netmask"),
+    tinc_ip             => lookup("network.self_internal_ip"),
+    tinc_netmask        => lookup("network.self_internal_netmask"),
     tinc_other_networks => $tinc_other_networks,
   }
 }
-- 
cgit v1.2.3